Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: np.setbufsize should raise ValueError for negative input #29774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: np.setbufsize should raise ValueError for negative input #29774

wants to merge 1 commit into from
+15 −0

Conversation

cibarbia05
Copy link

Closes #29651

This PR fixes an issue where np.setbufsize silently accepted negative
values. Passing a negative value now raises a ValueError with a clear
error message.

Changes

  • Added a check in np.setbufsize to raise ValueError when size < 0.
  • Added a new unit test test_negative_value_raises in
    numpy/_core/tests/test_umath.py.

Example

>>> import numpy as np
>>> np.setbufsize(-5)
Traceback (most recent call last):
    ...
ValueError: buffer size must be non-negative

@cibarbia05
BUG: np.setbufsize should raise ValueError for negative input
a9bbd23 
np.setbufsize previously accepted negative values silently.
This commit adds input validation so that a ValueError is raised
when a negative buffer size is provided, and adds a regression test
to cover this behavior.

Closes numpy#29651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

np.setbufsize accepts negative values silently instead of raising an error
1 participant
@cibarbia05