Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mattip
Copy link
Member

@mattip mattip commented Nov 10, 2025

Fixes #30187 by using the pure-python pykg-config. A possible improvement would be to add pykg-config as a build requirement.

@github-actions github-actions bot added the 36 - Build Build related PR label Nov 10, 2025
@mattip
Copy link
Member Author

mattip commented Nov 10, 2025

CI is passing. I think it is fine for now to leave installing it as part of the CI environment, since we also assume there is a pkg-config available in posix builds. We don't explicitly mention how to install pkg-config in the building page. We do mention it in passing as part of the ""conda env" tab.

Edit: actually, the wheel workflow failed but gave no indication of a problem ☹️

@charris
Copy link
Member

charris commented Nov 10, 2025

The numpy-release builds use also use choco to install pkgconfiglite, I'm guessing cibuildwheel requires it.

@mattip
Copy link
Member Author

mattip commented Nov 10, 2025

Bleh. The package does not work, it seems I was misled by a package installed with perl on the windows images. Closing

@rgommers
Copy link
Member

A possible improvement would be to add pykg-config as a build requirement.

This is now moot, but: we shouldn't do that so easily, it's not a Python package and it's not needed for almost all build scenarios.

This PR reminded me of gh-26574, which we really should find some time to finish. Might need a Christmas holiday ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

36 - Build Build related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows builds failing after failure to download pkg-config-lite.

3 participants