ENH,MAINT: rewrite np.fix to use np.trunc internally #30197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, exactly, thanks! I suspect you'll need this one small typing fixup also to make CI pass. |
Member
|
Thanks @hellerve, this fixes the regression and hopefully nobody actually notices the change :). |
cakedev0
pushed a commit
to cakedev0/numpy
that referenced
this pull request
Dec 5, 2025
* DEP: rewrite np.fix to use np.trunc internally * TST: add trunc to object for ufunclike tests
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
* DEP: rewrite np.fix to use np.trunc internally * TST: add trunc to object for ufunclike tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #30098, this PR is a break-out PR to rewrite
np.fixto usenp.truncinternally. @seberg I hope I understood your comment in #30098 (comment) correctly.This PR should have no observable effects except maybe a speed-up of
np.fix.Cheers