Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: convolve: fix incorrect error message for empty input - #30306

Closed
jorenham wants to merge 1 commit into
numpy:mainfrom
jorenham:convolve-error-message
Closed

BUG: convolve: fix incorrect error message for empty input#30306
jorenham wants to merge 1 commit into
numpy:mainfrom
jorenham:convolve-error-message

Conversation

@jorenham

@jorenham jorenham commented Nov 26, 2025

Copy link
Copy Markdown
Member

Closes #30272

before:

In [1]: np.convolve(a=[], v=[1])
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[1], line 1
----> 1 np.convolve(a=[], v=[1])

File ~/.local/share/uv/tools/ipython/lib/python3.14/site-packages/numpy/_core/numeric.py:902, in convolve(a, v, mode)
    900     raise ValueError('a cannot be empty')
    901 if len(v) == 0:
--> 902     raise ValueError('v cannot be empty')
    903 return multiarray.correlate(a, v[::-1], mode)

ValueError: v cannot be empty

after:

In [1]: np.convolve(a=[], v=[1])
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[1], line 1
----> 1 np.convolve(a=[], v=[1])

File ~/Workspace/numpy/build-install/usr/lib/python3.11/site-packages/numpy/_core/numeric.py:897, in convolve(a, v, mode)
    895 a, v = array(a, copy=None, ndmin=1), array(v, copy=None, ndmin=1)
    896 if len(a) == 0:
--> 897     raise ValueError('a cannot be empty')
    898 if len(v) == 0:
    899     raise ValueError('v cannot be empty')

ValueError: a cannot be empty

@jorenham

Copy link
Copy Markdown
Member Author

Woops, dupe of #30277

@jorenham jorenham closed this Nov 26, 2025
@jorenham
jorenham deleted the convolve-error-message branch November 26, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: numpy.convolve raises misleading ValueError on empty inputs due to internal variable swapping

1 participant