BUG: Show allocatable arrays in dir() for f2py modules#30965
Merged
Conversation
c7bad11 to
0791365
Compare
dir() for f2py modules
ff3a5f8 to
9a12dbd
Compare
Member
|
Makes sense and works nicely. Why is the test in |
9a12dbd to
7ee18ee
Compare
Member
Author
Thanks for the test ^_^
Ah, no, there was an allocatable array so I reused it while testing, but I've moved it now. |
Add a __dir__ method to PyFortranObject that includes variable names from the defs array (which contains allocatable arrays) alongside the regular dict keys. Previously dir() only showed dict contents, hiding allocatable variables that are handled dynamically via getattr. Closes numpy#27696
7ee18ee to
09f1a43
Compare
Member
|
Thanks @HaoZeke. Still a bit weird that the test uses a file from the src/regressions directory, but that is a small paper cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
__dir__method toPyFortranObjectthat includes all defs names (routines, variables, and allocatable arrays), not just the keys in the object dict. Previously, allocatable arrays were accessible via getattr but invisible todir()becausePyFortranObject_Newonly populated the dict with routines and non-allocatable variables.Closes #27696
cc @2sn (sorry for the long delay)