BUG: Fix regression in arr.conj()#31453
Merged
Merged
Conversation
I'll make these helpers static-inline functions on main. Unfortunately, this doesn't just cause wrong promotion for bool->uint8 in `arr.conj()`, but it also leads to all other non-complex types returning unnecessary copies which seems like a pretty unfortunate regression, even if it might not be very visible in practice. I am suspecting we may need a 2.4.6 for this :(
Member
|
Thanks Sebastian, seem simple enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll make these helpers static-inline functions on main. Unfortunately, this doesn't just cause wrong promotion for bool->uint8 in
arr.conj(), but it also leads to all other non-complex types returning unnecessary copies which seems like a pretty unfortunate regression, even if it might not be very visible in practice.I am suspecting we may need a 2.4.6 for this :(
(No AI)