BUG: core: Don't call INCREF/DECREF on descr in NpyStringAcquireAllocator.#31456
Conversation
|
I included the crasher that @jeromekelleher provided in gh-31415 as a test. By increasing |
900d782 to
4805101
Compare
|
Thanks for the speedy fix @WarrenWeckesser ❤️ |
We may want to have a multi-threaded test, but not with explicit |
Was just confirming that it works: But we don't need any threading at all. We just need to add a parametrization for existing tests with >500 elements or so (let's do 2000 maybe). We have debug test runs in the test-suite, and these already hit it reliably, the only problem is that the tests don't cover larger tests. |
Which tests are those? |
|
The EDIT: E.g. |
This case is a regression test for numpygh-31415 when run in a debug build.
4805101 to
4f81b67
Compare
|
I removed the multi-threaded test and added the test case suggested by @seberg. |
|
Thanks Warren! |
|
@ngoldbaum, thanks for finding my mistake 😳. |
|
No problem, I really appreciate you taking on the fix :) |
…ator. (#31456) (#31460) Co-authored-by: Warren Weckesser <[email protected]>
Remove incorrect calls of Py_INCREF(descr) and Py_DECREF(descr) in the RAII object NpyStringAcquireAllocator.
Closes gh-31415.
AI Disclosure
No AI tools used.