BUG: handle length-0 axes correctly in ufunc.reduce without identity #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In numpy 1.6, reduction operations with no identity (e.g. numpy.maximum) gave an error iff they were asked to reduce a 0-element dimension. This regressed during the 1.7 development cycle, so that they started giving an error if *any* dimension had 0 elements, even ones that were not reduced over. Fixes bug numpy#2078.
|
WTF? The one failure reported by Travis-CI is with Python 2.5, it's a test unrelated to this change, and I can't reproduce it here. The failing test is: and what we're getting for I suspect that what this is saying is that numpy is in fact buggy in how it handles these assignments, but that this test has mostly been accidentally passing by chance. |
|
Re: the test failure: http://mail.scipy.org/pipermail/numpy-discussion/2012-June/063010.html Anyway, I think this PR itself is fine. |
|
Looks good to me. |
njsmith
added a commit
that referenced
this pull request
Jul 6, 2012
BUG: handle length-0 axes correctly in ufunc.reduce without identity
This was referenced Oct 16, 2012
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vmla[q]_f64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In numpy 1.6, reduction operations with no identity
(e.g. numpy.maximum) gave an error iff they were asked to reduce a
0-element dimension. This regressed during the 1.7 development cycle,
so that they started giving an error if any dimension had 0
elements, even ones that were not reduced over. Fixes bug #2078.