ENH: reduce the alignment requirement for complex arrays on x86 #3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4164,7 +4173,13 @@ set_typeinfo(PyObject *dict) | |||
| #endif | |||
| NPY_@name@, | |||
| NPY_BITSOF_@name@, | |||
| /* alignment, platforms without unaligned access need double | |||
There was a problem hiding this comment.
Umm, multiline comment like so:
/*
* blah
*/
|
Is this safe to backport without the changes to |
|
it should be |
|
oh no shold be fine, the asserts request the size of the types actually loaded, which are just doubles. |
x86 can deal with unaligned memory access so it does not need to align complex types to 2 * sizeof(T) for the dtype transfers which work on the full complex number. closes numpy#3768 Does not fix that new complex arrays are reported as aligned when the allocator does not provide the required alignment.
|
fixed comments, and tested debug mode on linux32. |
|
but it will fail with -maligndouble and win32, this is not worth the trouble, closing. |
|
So it goes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86 can deal with unaligned memory access so it does not need to align
complex types to 2 * sizeof(T) for the dtype transfers which work on the
full complex number.
closes #3768
Does not fix that new complex arrays are reported as aligned when
the allocator does not provide the required alignment.