ENH: Implemented ma.append #4339
Conversation
| @@ -7258,3 +7258,8 @@ def __call__(self, a, *args, **params): | |||
| zeros_like = np.zeros_like | |||
|
|
|||
| ############################################################################### | |||
| def append(a, b, axis=None): | |||
There was a problem hiding this comment.
this needs a docstring, see other numpy functions for the formatting
There was a problem hiding this comment.
still needs
.. versionadded:: 1.9.0
on line of its own above Parameters, see e.g. np.partition
|
I addressed @juliantaylor comments. I also reviewed the implementation of a related function |
| b = np.ma.masked_values([[4, 5, 6], [7, 8, 9]], 7) | ||
|
|
||
| # When `axis` is specified, `values` must have the correct shape. | ||
| assert_raises(ValueError, np.append, a, b, axis=0) |
There was a problem hiding this comment.
I guess this should be np.ma.append
|
can you still squash the commits into one please, it simplifies backporting and regression hunting. |
|
Sure - I was just waiting for the final go ahead. It is easier to keep track of the comments with multiple commits. |
|
when you make changes to be reviewed please also add a comment, github does not send notifications when a PR changes. |
|
@juliantaylor This PR has been updated. |
ENH: Implemented ma.append
|
loooks good, thanks |
Fixes #2219.