ENH: allow subclass overrides by removing explicit ndarray methods #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhvk Needs a rebase. |
| @@ -205,7 +205,10 @@ now released for fancy indexing and ``np.where``. | |||
| MaskedArray support for more complicated base classes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Built-in assumptions that the baseclass behaved like a plain array are being | |||
| removed. In particalur, ``repr`` and ``str`` should now work more reliably. | |||
| removed. In particalur, ``repr`` and ``str`` should now work more reliably, | |||
There was a problem hiding this comment.
there is a typo in "particalur"
85443c9 to
338d047
Compare
|
@charris - OK, rebased (and spelling error corrected). I thought this one was a pretty straightforward improvement. |
|
Are there any tests you could add to this that don't rely on the units package? This is a fairly substantial change, so it will be interesting to see if anything breaks. |
|
@mhvk I going to merge this, but it would still be good if you could add some tests. Maybe a sort of simplified units class? |
charris
added a commit
that referenced
this pull request
Jun 15, 2015
ENH: allow subclass overrides by removing explicit ndarray methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on of #4586, and it removes all direct use of
ndarraymethods, changing, e.g.,ndarray.__iadd__(self._data, ...)toself._data.__iadd__(...). The idea again is to not presume what data is being held (though it is not as essential to making maskedQuantitywork as is #4586).