BUG: Fix string to uint64 conversion on 32-bit platforms #4712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should probably warn on overflow here, but ENOTIME currently |
| #if defined HAVE_STRTOLL | ||
| return strtoll(str, endptr, base); | ||
| #elif defined _MSC_VER | ||
| return _strtoi64(str, endptr, base); |
There was a problem hiding this comment.
This returns __int64, which is more specific than long long. Any reason that strtoll won't be available for MSC? It is in at least VS2013.
There was a problem hiding this comment.
I'm hoping int64 and long long is the same in VC
if it has strtoll it will use it even with VC (assuming setup.py detects it)
|
LGTM, thanks Julian. |
charris
added a commit
that referenced
this pull request
May 15, 2014
BUG: Fix string to uint64 conversion on 32-bit platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-4575