MSVC fixes#5207
Merged
Merged
Conversation
The functions are macros in msvc which we undefine and redeclare in npy_math. Since we now generate the ldexpl and frexpl ufuncs in numpygh-4852 this was broken by the extra logic for them in npy_config.h
cbrt does not set the invalid flag on nan input as all inputs are valid. Fix the fallback to behave the same.
Member
There was a problem hiding this comment.
Not sure about this one, the same code is in v1.8.2. What is the motivation? I'm sure there is a reason...
Contributor
There was a problem hiding this comment.
I don't think its necessary. The motivation was, AFAICT, that since frexp and ldexp were wrapped by hand the logic for using the double versions for long double also needed to be by hand. In npy_math we just wrap these like any other now, meaning that we always call the double version for long double if we don't have an explicit l version, so this logic shouldn't be necessary.
Contributor
|
Thanks for cleaning this up, Julian. This breakage certainly goes on me. |
Member
|
@ewmoore OK, we will give it a shot. The previous was also a gamble... |
Member
|
Thanks Julian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix undefined reference of ldexpl/frexpl and the cbrt fallback raising an invalid flag on nan input.