Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: Simplified fix, Overflow in tan and tanh for large complex values. #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 7 commits into from
Feb 13, 2015
Merged

BUG: Simplified fix, Overflow in tan and tanh for large complex values. #5518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
de681b7
ENH: Detect all functions in complex.h
charris Jan 28, 2015
c1f7e0b
ENH: Implement more fallback complex functions for npy_math.
ewmoore Jan 28, 2015
6906823
ENH: Use the new complex functions in npymath for our ufuncs.
ewmoore Jan 28, 2015
34b5f9f
TST: Add tests for complex ufuncs.
ewmoore Jan 29, 2015
44d0c52
BUG: Do not use system cpow directly.
charris Jan 29, 2015
3a4127b
BUG: Disable broken complex trig functions for early linux glibc.
charris Jan 30, 2015
f9c3776
DOC: Document changes in npymath library.
charris Feb 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: Disable broken complex trig functions for early linux glibc. 
The library functions casin, casinh, catan, catanh are inaccurate
in glibc version < 2.16, so use the numpy fallback functions for
those.
  • Loading branch information
@charris
charris committed Feb 13, 2015
commit 3a4127bf53bc116eb5872d44e76ad498215b8637
1 change: 1 addition & 0 deletions numpy/core/setup_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def check_api_version(apiversion, codegen_dir):
# sse headers only enabled automatically on amd64/x32 builds
"xmmintrin.h", # SSE
"emmintrin.h", # SSE2
"features.h", # for glibc version linux
]

# optional gcc compiler builtins and their call arguments and optional a
Expand Down
53 changes: 47 additions & 6 deletions numpy/core/src/private/npy_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
#include "config.h"
#include "numpy/numpyconfig.h"

/* Disable broken MS math functions */
#if defined(_MSC_VER) || defined(__MINGW32_VERSION)
#undef HAVE_ATAN2
#undef HAVE_HYPOT
#endif

/*
* largest alignment the copy loops might require
* required as string, void and complex types might get copied using larger
Expand All @@ -21,9 +15,56 @@
*/
#define NPY_MAX_COPY_ALIGNMENT 16

/* blacklist */

/* Disable broken Sun Workshop Pro math functions */
#ifdef __SUNPRO_C

#undef HAVE_ATAN2
#undef HAVE_ATAN2F
#undef HAVE_ATAN2L

#endif

/* Disable broken MS math functions */
#if defined(_MSC_VER) || defined(__MINGW32_VERSION)

#undef HAVE_ATAN2
#undef HAVE_ATAN2F
#undef HAVE_ATAN2L

#undef HAVE_HYPOT
#undef HAVE_HYPOTF
#undef HAVE_HYPOTL

#endif

/* Disable broken gnu trig functions on linux */
#if defined(__linux__) && defined(__GNUC__)

#if defined(HAVE_FEATURES_H)
#include <features.h>
#define TRIG_OK __GLIBC_PREREQ(2, 16)
#else
#define TRIG_OK 0
#endif

#if !TRIG_OK
#undef HAVE_CASIN
#undef HAVE_CASINF
#undef HAVE_CASINL
#undef HAVE_CASINH
#undef HAVE_CASINHF
#undef HAVE_CASINHL
#undef HAVE_CATAN
#undef HAVE_CATANF
#undef HAVE_CATANL
#undef HAVE_CATANH
#undef HAVE_CATANHF
#undef HAVE_CATANHL
#endif
#undef TRIG_OK

#endif /* defined(__linux__) && defined(__GNUC__) */

#endif