DOC: Updated docstring for histogram2d as suggested in issue #5538#5567
Merged
Conversation
Member
There was a problem hiding this comment.
Shouldn't this be "is the number of bins and array is the bin edges"?
Also, added unittest for [int, array] combination arguments
6458925 to
40fd50e
Compare
Contributor
Author
|
@jaimefrio I have edited the docstring. (I did a rebase as it was a minor text edit, let me know if I shouldn't have...) |
jaimefrio
added a commit
that referenced
this pull request
Feb 13, 2015
DOC: Updated docstring for histogram2d as suggested in issue #5538
Member
|
Thanks Asmund, merged. Github seemed happy, so whatever you did probably was right. I think the typical way is to amend the last commit and then force push to your fork. Also, if you had had a "closes #5538" in your commit message, github would have closed it automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, added unittest for [int, array] combination arguments.