BUG: check for nargs <= NPY_MAXARGS in ufunc constructor #5673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PyErr_Format(PyExc_ValueError, | ||
| "Cannot construct a ufunc with more than %d operands " | ||
| "(%d input%sand %d output%swere requested)", | ||
| NPY_MAXARGS, nin, nin != 1 ? "s " : " ", nout, |
There was a problem hiding this comment.
Heh. I wonder if requested number were: inputs = %d and outputs = %d. would do?
|
LGTM modulo error message bike shedding. |
0690a62 to
c4db04b
Compare
|
Just wait for the new paint on the bike shed to dry, and it should be ready to merge. ;-) |
charris
added a commit
that referenced
this pull request
Mar 13, 2015
BUG: check for nargs <= NPY_MAXARGS in ufunc constructor
|
Love the color ;) Thanks Jaime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5672