TST: attempt to make test_load_refcount deterministic #6576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy/lib/tests/test_io.py
Outdated
There was a problem hiding this comment.
may be we can disable/enable gc to prevent automatic call, something like:
gc.disable()
try:
gc.collect()
np.load(f)
nobj=gc.collect()
finally:
gc.enable()
assert_equal(nobj, 0)There was a problem hiding this comment.
Sure, why not :-). Updated.
Use a different strategy to detect whether np.load creates cycles. Fixes numpygh-6571, I hope.
60efeb0 to
0befb0b
Compare
|
Guess the only way to be sure is put it in and wait ;) Thanks Nathaniel. |
charris
added a commit
that referenced
this pull request
Oct 29, 2015
TST: attempt to make test_load_refcount deterministic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different strategy to detect whether np.load creates cycles.
Fixes gh-6571, I hope.