Revert "Merge pull request #6376 from charris/backport-gh-6361" #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a600a5c, reversing changes made to 77fb742. The expanded warning led to incompatibilities with with Numpy 1.9, which had already the future behavior for the cases covered by the extended warning conditions. Rather than roll back the behavior of 1.9 only to reimplement it later, it is thought better to preserve it and move on.
|
LGTM Should we also add a test to here and master, checking that 1.9 behavior reported in #6575 remains? |
|
I don't think so, it feels like a bug at this point and 1.10 should only be minor fixes after 1.10.2. Hopefully 1.11 branches end of Feb and goes full future. I think there is already enough new material in master for 1.11 if we are on an accelerated release schedule, but branching in Dec might be a bit early ;) |
|
Sorry, I meant should we add a test for the "future" behavior, to make sure it remains as it is in 1.9 and will be in 1.10.2 after this is merged. I have been quietly pondering whether to suggest going full-speed-ahead and branching 1.11 in November, but I figured I'd wait until 1.10 settled down before deciding :-) |
charris
added a commit
that referenced
this pull request
Oct 30, 2015
Revert "Merge pull request #6376 from charris/backport-gh-6361"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a600a5c, reversing
changes made to 77fb742.
The expanded warning led to incompatibilities with with Numpy 1.9, which
had already the future behavior for the cases covered by the extended
warning conditions. Rather than roll back the behavior of 1.9 only to
reimplement it later, it is thought better to preserve it and move on.
See #6575.