BUG: Fixed masked array behavior for scalar inputs to np.ma.atleast_*d #7823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def __call__(self, x, *args, **params): | ||
| func = getattr(np, self.__name__) | ||
| _d = func(tuple([np.asarray(a) for a in x]), *args, **params) | ||
| _m = func(tuple([getmaskarray(a) for a in x]), *args, **params) |
There was a problem hiding this comment.
the list should not be needed, you can create a tuple from a generator (though it doesn't really make a significant difference here)
There was a problem hiding this comment.
This is a direct copy of old version line ~272. I thought there were some issues with using a generator expression in older versions of Python, so I kept it this way. Could be wrong though.
There was a problem hiding this comment.
we only support 2.6 (or even 2.7 now?) so that should not be an issue
but its also not necessary to change it, more of a keep in mind that you can do that comment :)
|
thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this bug are extracted from #7804, where they are duplicated. This PR is intended to be non-controversial since it is just a bug-fix.