BUG: Fix handling of clip out= argument order properly #7873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fastclip doesn't allow for the in and out to have different orders, this fix forces the output to have the same order as the in. Closes #7633
|
I guess we have both kind of ways in numpy probably. I guess this might be a bit faster usually, but on the other hand going to slow mode more often when |
|
It would also be a nice, but a bit more involved, option to see if we can't replace the whole function with a ufunc.... |
|
Tried to implement a ufunc version of clip in #7876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fastclip doesn't allow for the in and out to have different orders, this fix forces the output to have the same order as the input.
Closes #7633
Alternatively, I could call the slow clip function in this case or change the in array to the proper order if needed. Would either of those methods be preferable?