BUG: Fix ndarray.tofile large file corruption in append mode. #8341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…append file mode Fixes by using the flag `FALLOC_FL_KEEP_SIZE` (=1) in the `fappend` call. Fixes numpy#8329
charris
added a commit
to charris/numpy
that referenced
this pull request
Dec 5, 2016
numpygh-8341 was a backport and the tests were fixed for pypy, but the corresponding constant PYPY is undefined in 1.11.x.
charris
added a commit
that referenced
this pull request
Dec 5, 2016
TST: Fix tests in PR #8341 for NumPy 1.11.x
jsonn
referenced
this pull request
in jsonn/pkgsrc
Jan 1, 2017
========================== NumPy 1.11.3 Release Notes ========================== Numpy 1.11.3 fixes a bug that leads to file corruption when very large files opened in append mode are used in ``ndarray.tofile``. It supports Python versions 2.6 - 2.7 and 3.2 - 3.5. Wheels for Linux, Windows, and OS X can be found on PyPI. Contributors to maintenance/1.11.3 ================================== A total of 2 people contributed to this release. People with a "+" by their names contributed a patch for the first time. - Charles Harris - Pavel Potocek + Pull Requests Merged ==================== - `#8341 <https://github.com/numpy/numpy/pull/8341>`__: BUG: Fix ndarray.tofile large file corruption in append mode. - `#8346 <https://github.com/numpy/numpy/pull/8346>`__: TST: Fix tests in PR #8341 for NumPy 1.11.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8335.
Fixes by using the flag FALLOC_FL_KEEP_SIZE (=1) in the fappend call.
Fixes #8329