BUG: Fix np.lib.nanfunctions on object arrays #9013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caedf95 to
c87976b
Compare
c87976b to
a77709c
Compare
eric-wieser
commented
Apr 29, 2017
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter('always') | ||
| # assert_equal does not work on object arrays of nan | ||
| assert_equal(list(np.nanmin(arr, axis=1)), [1.0, 4.0, np.nan]) |
There was a problem hiding this comment.
More details at #9023
|
LGTM, thanks Eric. |
BvB93
pushed a commit
to BvB93/numpy
that referenced
this pull request
Sep 5, 2021
… arrays Use the same approach as in numpy#9013
howjmay
pushed a commit
to howjmay/numpy
that referenced
this pull request
Sep 29, 2021
… arrays Use the same approach as in numpy#9013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround until the harder problems of #9009 and #8975 are fixed.
Fixes #8974 and #9008