MAINT/DOC: Stop pretending that np.{x} and builtins.{x} are different #9508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for x in {int, bool, str, float, complex, object}
This doesn't change any external behaviour. `long` is missing in python 3, so np.long is still useful
eric-wieser
commented
Aug 1, 2017
| @@ -35,7 +35,7 @@ def test_float_types(): | |||
| """ Check formatting. | |||
|
|
|||
| This is only for the str function, and only for simple types. | |||
| The precision of np.float and np.longdouble aren't the same as the | |||
There was a problem hiding this comment.
Only manual lines in this patch, to avoid the claim that float is not the same as float. Of course, the original was wrong too.
|
Hmm, experimented with online conflict resolution but didn't work -- I updated the And can't figure out how to revert the commit online. Will fix ... |
|
Rebased in #9517, so closing this. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For x in {int, bool, str, float, complex, object}.
longandunicodeare missing in python 3, sonp.longis still useful (althoughnp.compat.longmight still be clearer).This doesn't change any external behaviour.
It may be difficult to deprecate these (#6103), but there's no reason we should be using them within our own code, or within our documentation.
Simple find and replace of
np\.(int|complex|object|str|bool|float)\bwith$1.