Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement copysign, sign, and signbit ufuncs#122

Merged
SwayamInSync merged 4 commits intonumpy:mainfrom
juntyr:sign2
Jul 26, 2025
Merged

Implement copysign, sign, and signbit ufuncs#122
SwayamInSync merged 4 commits intonumpy:mainfrom
juntyr:sign2

Conversation

@juntyr
Copy link
Contributor

@juntyr juntyr commented Jul 23, 2025

Supersedes #118

Progress on numpy/numpy-quaddtype#37

  • implements the sign, signbit, and copysign ufuncs
  • extends unary unfunc tests
  • adds extra const annotations to the ops implementations

@juntyr juntyr mentioned this pull request Jul 23, 2025
Closed
@juntyr
Copy link
Contributor Author

juntyr commented Jul 23, 2025

@SwayamInSync A manual rebase was easier for me, this PR should now be good to go

@juntyr juntyr mentioned this pull request Jan 16, 2026
Closed
11 tasks
@juntyr
Copy link
Contributor Author

juntyr commented Jul 25, 2025

@SwayamInSync @ngoldbaum Is there anything left to do so that this PR can be merged?

@SwayamInSync
Copy link
Member

SwayamInSync commented Jul 25, 2025

@SwayamInSync @ngoldbaum Is there anything left to do so that this PR can be merged?

Yes just a small edit, in the earlier review I mentioned a variable shadowing issue, can you please fix that, it is not causing any error right now because inside loop statements the lists gets interpreted first. So it captures the original value. But this is confusing and error-prone.

@juntyr
Copy link
Contributor Author

juntyr commented Jul 26, 2025

@SwayamInSync @ngoldbaum Is there anything left to do so that this PR can be merged?

Yes just a small edit, in the earlier review I mentioned a variable shadowing issue, can you please fix that, it is not causing any error right now because inside loop statements the lists gets interpreted first. So it captures the original value. But this is confusing and error-prone.

I'm unfortunately unable to find that review, could you please link it for me?

SwayamInSync
SwayamInSync requested changes Jul 26, 2025
View reviewed changes
SwayamInSync
SwayamInSync approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@SwayamInSync SwayamInSync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@SwayamInSync SwayamInSync merged commit 0944dfa into numpy:main Jul 26, 2025
6 checks passed
@juntyr juntyr deleted the sign2 branch July 27, 2025 15:22
@ngoldbaum
Copy link
Member

ngoldbaum commented Jul 28, 2025

I'm glad you two are handling reviews between each other. Please feel free to ping me if you'd like an additional eye or opinion on anything.

@SwayamInSync SwayamInSync mentioned this pull request Jan 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwayamInSync SwayamInSync SwayamInSync approved these changes

Assignees

No one assigned

Labels

numpy_quaddtype

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juntyr @SwayamInSync @ngoldbaum