Make void to quad give error than segfault#147
Merged
SwayamInSync merged 4 commits intonumpy:mainfrom Sep 9, 2025
Merged
Conversation
void->quad gives error than segfault
Member
Author
|
Let's do a release after this, what should be the versioning name? @ngoldbaum |
ngoldbaum
reviewed
Sep 9, 2025
| void *NPY_UNUSED(auxdata)) | ||
| { | ||
| PyErr_SetString(PyExc_RuntimeError, "void_to_quad_strided_loop should not be called"); | ||
| return -1; |
Member
There was a problem hiding this comment.
We could probably also do something similar in NumPy, but this is fine for now.
Member
|
Probably 0.2 because of all the packaging changes. |
Member
Author
Got it |
Member
Author
|
GitHub is depreciating the macos-13 runner image maybe that's why it is getting slower than others. From next versioning we can change our CI to use macos-14 and 15 images |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #145