ENH: Make SLEEF Dependency and allow subproject fallback#170
Merged
SwayamInSync merged 4 commits intonumpy:mainfrom Oct 14, 2025
Merged
ENH: Make SLEEF Dependency and allow subproject fallback#170SwayamInSync merged 4 commits intonumpy:mainfrom
SwayamInSync merged 4 commits intonumpy:mainfrom
Conversation
ngoldbaum
reviewed
Oct 13, 2025
Member
|
Awesome, looks good at a quick glance. I'd say to merge, assuming the tests pass! |
Member
Author
|
I tested this on mac with all 3 possible scenarios
worked in all, should be passing all tests as CI here is only following 3rd condition |
Member
Author
|
Merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extension of work did in
0.2xto make it compatible with the cross-compilation over conda-forge