FEAT: fabs ufunc implementation#180
Merged
SwayamInSync merged 3 commits intonumpy:mainfrom Oct 17, 2025
Merged
Conversation
Member
Author
|
similar to absolute, just does not handle the complex types (so do we) hence registering absolute as fabs |
juntyr
reviewed
Oct 17, 2025
juntyr
approved these changes
Oct 17, 2025
Contributor
juntyr
left a comment
There was a problem hiding this comment.
LGTM, with the added comment
Member
Author
|
Let's take this in as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for the
np.fabsuniversal function (ufunc) for the customQuadPrecisiondtype, ensuring it behaves identically tonp.absolutefor real numbers. The implementation includes both the underlying C++ registration and comprehensive tests for various input values. The release tracker documentation is also updated to reflect this new support.Feature addition:
fabsufunc for theQuadPrecisiondtype in the C++ extension by registering it ininit_quad_unary_ops. This ensures thatnp.fabscan be used with quad-precision numbers.Testing:
test_fabsintest_quaddtype.pyto verify the correctness ofnp.fabsforQuadPrecisionscalars and arrays, covering positive, negative, zero, special, and small values. The test also checks that the sign of zero is positive after applyingfabs.Documentation:
release_tracker.mdto markfabsas supported for both the ufunc and its corresponding Python API, reflecting the new implementation status.