FEAT: conj and conjugate ufunc implementation#182
Merged
SwayamInSync merged 4 commits intonumpy:mainfrom Oct 17, 2025
Merged
Conversation
juntyr
reviewed
Oct 17, 2025
Contributor
juntyr
left a comment
There was a problem hiding this comment.
Could this PR have a very basic no-op test (what do we do for np.positive)?
Member
Author
for np.positive and others we just compare against the numpy's answer on float64 with some relative tolerance |
Member
Author
|
One reason I didn't add the tests because this covers only the real part of conjugate functionality i.e only returning the value back like identity. |
Contributor
|
I still think it would be good to test this, otherwise one could implement the function by returning pi |
Member
Author
|
Coool tests are added, lets merge this as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for the
conjugateandconjunary operations for quad and long double types, treating them as no-ops since these types represent real numbers. It also updates documentation to reflect this new support.New unary operations support
quad_conjugateandld_conjugatefunctions toops.hpp, implementing conjugate as a no-op for real numbers. [1] [2]conjugateunary operation ininit_quad_unary_opsand documented thatconjis an alias, so no separate registration is needed.Documentation update
release_tracker.mdto markconjandconjugateas supported for both quad and long double types.