FEAT: All logical ufunc implementation#188
Merged
SwayamInSync merged 5 commits intonumpy:mainfrom Oct 18, 2025
Merged
Conversation
Contributor
|
Why do we need the extra -0.0 and +0.0 comparison for SLEEF? They should already compare equal (if not, do we already special-case handle them in the other comparison functions)? |
Member
Author
Nope sorry I was thinking something else, it can compare correctly |
juntyr
approved these changes
Oct 18, 2025
Contributor
juntyr
left a comment
There was a problem hiding this comment.
LGTM, with the one comment addressed
Member
Author
|
Merging this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for logical operations (
logical_and,logical_or,logical_xor, andlogical_not) for the QuadPrecision data type, ensuring their behavior matches NumPy's semantics. The implementation covers both Sleef quad and long double backends, integrates these operations into the ufunc system, and provides comprehensive tests to verify correctness and compatibility.Logical operations implementation:
Sleef_quadandlong doublebackends inops.hpp, including truthiness checks and all four logical operations (and,or,xor,not).Ufunc integration:
logical_and,logical_or,logical_xor) inumath/comparison_ops.cpp.umath/unary_ops.cpp. [1] [2]Testing and documentation:
test_quaddtype.py, comparing QuadPrecision results against NumPy's float64 behavior.release_tracker.mdto mark logical operations as implemented and tested.