fix(collection): avoid double update of some record by using the hash column as index #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnabaz
requested changes
Apr 10, 2025
There was a problem hiding this comment.
Thanks, @elevatebart, for the PR; it's a nice fix.
Added two change requests before
Comment on lines
-194
to
-196
| if (opts.hashColumn !== false) { | ||
| values.push(`'${valuesHash}'`) | ||
| } |
There was a problem hiding this comment.
A system with no hashColumn would not benefit from this improvement.
I will set it up.
src/utils/collection.ts
Outdated
| values.push(`'${valuesHash}'`) | ||
| } | ||
|
|
||
| const valuesWithHash = opts.hashColumn !== false ? [...values, `'${valuesHash}'`] : values |
There was a problem hiding this comment.
I'm thinking of removing hashColumn option and add it to all, it will simplify the logic here.
I added this option to avoid adding __hash__ to the development cache table, which causes SQL to fail. But forcing cache cleanup in the new version would be a better solution.
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
When two users on diferent parts of the world open the same un-deployed nuxt content powered website, they both trigger the deployment at the same time. Since it can take a moment for data to be synchronized, both can still be running the data at the same time, including the concatenation updates.
To avoid duplicating and therefore corrupting the data, I had the idea to use a temporary hash when inserting incomplete data:
example with the hash of the record being
123456798and the column namecontentWith this we prevent most corruption of data through multiple updates.
We still need a way to "repair" a system that has stopped deploying mid deployment.
But this should improve deployment stability slightly.
📝 Checklist