Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt): add warning in dev mode if layouts/pages do not have a single root node #5469

Merged
merged 12 commits into from
Aug 23, 2022
Merged

feat(nuxt): add warning in dev mode if layouts/pages do not have a single root node #5469

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d71cf3
feat(nuxt): add warning in dev mode if layouts/pages do not have a si…
danielroe Jun 15, 2022
910ef75
fix: type error
danielroe Jun 15, 2022
6f4ca9d
refactor: use `nextTick`
danielroe Jun 15, 2022
cd5c239
fix: wait to detect nodes until components are mounted
danielroe Aug 4, 2022
4ff94f0
fix: layout detection
danielroe Aug 4, 2022
b1821c0
test: add fixture to test for invalid root nodes
danielroe Aug 4, 2022
031f8dd
Merge branch 'main' into dx/root-nodes
pi0 Aug 22, 2022
cdda0ad
refactor: split type-only imports
pi0 Aug 22, 2022
acae0e9
improve messages
pi0 Aug 22, 2022
86a0f2b
update fixture
pi0 Aug 22, 2022
ee388ae
..ing? :)
pi0 Aug 22, 2022
34cf53a
concat warns
pi0 Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
concat warns 
what we are really testing is ensure exsistance of a specific warn not whole warnings behavior
  • Loading branch information
@pi0
pi0 committed Aug 22, 2022
commit 34cf53a80ed60377477976c9bd8ba23e4d332353
7 changes: 2 additions & 5 deletions test/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,8 @@ if (process.env.NUXT_TEST_DEV) {
it('should detect invalid root nodes in pages', async () => {
for (const path of ['1', '2', '3', '4']) {
const { consoleLogs } = await renderPage(joinURL('/invalid-root', path))

const consoleLogsWarns = consoleLogs.filter(i => i.type === 'warning')

expect(consoleLogsWarns.length).toEqual(1)
expect(consoleLogsWarns[0].text).toContain('does not have a single root node and will cause errors when navigating between routes')
const consoleLogsWarns = consoleLogs.filter(i => i.type === 'warning').map(w => w.text).join('\n')
expect(consoleLogsWarns).toContain('does not have a single root node and will cause errors when navigating between routes')
}
})

Expand Down