fix(ipx): always use ipx provider if external baseURL is provided
#1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nuxt-image with
|
| Latest commit: |
3e093cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e151d6d4.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-external-ipx.nuxt-image.pages.dev |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 62.91% 62.89% -0.02%
==========================================
Files 81 81
Lines 3772 3776 +4
Branches 431 432 +1
==========================================
+ Hits 2373 2375 +2
- Misses 1371 1373 +2
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
it's possible to use a self-hosted ipx instance and in this case we don't need to add an
/_ipxhandler. And we can support ipx even on non-node targets.in such a case, this PR avoids setting up the handler and doesn't disable ipx outside a node environment.