-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat(nuxt): pass server logs to client #25936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
β Live Preview ready!
|
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt-nightly@pr-25936 |
danielroe
commented
Feb 26, 2024
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt-nightly@pr-25936 |
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt-nightly@pr-25936 |
pi0
reviewed
Mar 15, 2024
pi0
approved these changes
Mar 15, 2024
atinux
approved these changes
Mar 15, 2024
Merged
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #25260
resolves #13470
β Type of change
π Description
This PR adds a new feature (can be disabled by setting
features.devLogs
tofalse
) which records all console events on the server (nitro runtime + vue runtime). It bundles up logs to the next request, and then continues to stream them to the client. Any logs that don't happen on the client are displayed in the console.A hook (which I envision being consumed by devtools - cc: @antfu) is called whenever new logs are available.
You can currently set
features.devLogs
tosilent
to disable them being output to the browser console while still being able to consume them in devtools, or elsewhere. I'm wondering if it makes sense for this to be the default, so things are less 'noisy'... (Thoughts very much welcome!)Here's a demo of logs being consumed by a custom hook +
vue-sonner
:CleanShot.2024-02-23.at.17.34.12.mp4
π Checklist