Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): produce valid css selector from useId #25969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(nuxt): produce valid css selector from useId #25969

merged 2 commits into from
Feb 27, 2024

Conversation

TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Feb 26, 2024 •
edited
Loading

🔗 Linked issue

#25949

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds an n in front of all results from useId and ensures that _ is used as separator instead of :, ensuring that the result can be used as CSS selector without sanitizing.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

danielroe
danielroe reviewed Feb 27, 2024
View reviewed changes
TheAlexLichter
TheAlexLichter commented Feb 27, 2024
View reviewed changes
@danielroe danielroe changed the title chore: let id's from useId be valid css selectors fix(nuxt): produce valid css selector from useId Feb 27, 2024
@danielroe danielroe merged commit 15a4a08 into main Feb 27, 2024
@danielroe danielroe deleted the chore/update-use-id branch February 27, 2024 10:57
This was referenced Feb 27, 2024
Closed
Merged
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAlexLichter @danielroe