Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): cache-bust payloads with build id #26068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2024
Merged

fix(nuxt): cache-bust payloads with build id #26068

merged 5 commits into from
Mar 6, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #15427

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This moves payload hashes to a query string and uses the build ID to provide cache-busting capability.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 March 4, 2024 10:57
@danielroe danielroe self-assigned this Mar 4, 2024
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe marked this pull request as draft March 4, 2024 11:17
@danielroe danielroe marked this pull request as ready for review March 4, 2024 11:28
@danielroe danielroe force-pushed the fix/hash-payloads branch from 1d78a09 to a74b4b1 Compare March 4, 2024 11:29
pi0
pi0 reviewed Mar 4, 2024
View reviewed changes
@danielroe danielroe mentioned this pull request Mar 5, 2024
Merged
9 tasks
@danielroe danielroe merged commit 209ae4a into main Mar 6, 2024
@danielroe danielroe deleted the fix/hash-payloads branch March 6, 2024 12:51
This was referenced Mar 6, 2024
Closed
Merged
@axelerod12
Copy link

Is it possible to include the build ID here as well?https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/core/runtime/nitro/renderer.ts#L434
https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/core/runtime/nitro/renderer.ts#L394

@danielroe
Copy link
Member Author

That's a good idea. I'd welcome a PR to do it @axelerod12 🙏

@danielroe danielroe mentioned this pull request Mar 27, 2024
Merged
8 tasks
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding hashes to the _payload.js files
3 participants
@danielroe @axelerod12 @pi0