Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #26142

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There can be race conditions when awaiting the initial check whether a promise already exists in prerender cache.

Actually the _sharedPrerenderCache supports sync operations to verify whether the promise exists so we can convert this function to sync.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe marked this pull request as draft March 8, 2024 10:22
@danielroe danielroe marked this pull request as ready for review March 8, 2024 15:54
@danielroe danielroe merged commit b7516a1 into main Mar 8, 2024
@danielroe danielroe deleted the fix/sync-prerender-cache branch March 8, 2024 17:03
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sharedPrerenderData doesn't share data while extending prerender.routes
1 participant