Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This resolves the deep directories of a number of key packages to enable full type safety when used with shamefully-hoist=false. It also refactors the existing implementation of this to make it more performant (by just doing it once rather than in the templates which run many times).

We also export some renderer types from #app so they will work when used with new TS bundler resolution.

With this, the following bugs are resolved with shamefully-hoist=false:

  • nitro runtime hooks are properly extended
  • key renderer types (like HTMLContext) now work
  • app config is correctly merged/typed
  • internal API types now flow through correclty

Later on we might want to do this automatically for dependencies added to auto imports, or make this list extensible.

cc: @pi0

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant