fix(vite): drop name prefix for client chunk file names #26203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have no hard feelings on this one as it can be easily configured by the user. |
8 tasks
2ebf6a2 to
293e748
Compare
|
@danielroe can you please confirm if nitrojs/nitro#2250 is blocking this PR or not? Thinking to move Nitro main to feature release mode. |
|
@pi0 Yes, it is. But don't want to mess with your release schedule. 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #13499
❓ Type of change
📚 Description
Revisiting my take on this, I think this is a reasonable change to make given that it will make chunks safer (without risk of being blocked by ad blockers).
It doesn't change entry (
entry.239847a.js) for ease of detecting it in the list or asset names (as I think it makes sense that this would preserve the file name).📝 Checklist