Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): only strip supported extensions when generating import types #26218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix(nuxt): only strip supported extensions when generating import types #26218

merged 3 commits into from
Mar 12, 2024

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Mar 12, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this problem

  const readFragment: typeof import('../../node_modules/.pnpm/[email protected][email protected]/node_modules/gql')['readFragment']

and fixed

  const readFragment: typeof import('../../node_modules/.pnpm/[email protected][email protected]/node_modules/gql.data')['readFragment']

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix: file extension replacement in module.ts fix(nuxt): only strip supported extensions when generating import types Mar 12, 2024
@productdevbook
Copy link
Member Author

we need to apply the same to nitro, can you handle that?

@danielroe danielroe merged commit 8010b04 into nuxt:main Mar 12, 2024
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Merged
@productdevbook productdevbook deleted the fix-declaration branch March 12, 2024 18:53
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@productdevbook @danielroe