fix(nuxt): auto imports regeneration timing #26249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antfu
commented
Mar 14, 2024
| }) | ||
|
|
||
| nuxt.hook('app:templatesGenerated', async () => { | ||
| await regenerateImports() |
There was a problem hiding this comment.
Previously we did regeneration (rescan) after all templates to avoid race conditions in #21934. But since unimport also use templates to generate those dts etc, so it means we missed the chance to update them - until this get triggered again - we are always one "tick" behind.
This PR makes sure regenerateImports always update (only) the unimport templates. Thus we also need some mechanism to dedupe and avoid circular update
danielroe
reviewed
Mar 14, 2024
danielroe
approved these changes
Mar 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
In the review comments
📝 Checklist