Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(nuxt): add clear function to async data #26259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 17, 2024
Merged

feat(nuxt): add clear function to async data #26259

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba41ca7
feat(nuxt): add `clear` function to async data
DamianGlowala Mar 14, 2024
51e12b1
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 14, 2024
69155a5
fix: pass `nuxtApp` to `clearNuxtDataByKey`
DamianGlowala Mar 14, 2024
0292ffa
Merge branch 'main' into feat/async-data-clear-fn
danielroe Mar 16, 2024
61c9113
fix: cancel pending promises when clearing data
danielroe Mar 16, 2024
89648ba
fix: move to correct block
danielroe Mar 16, 2024
9efaf07
Merge remote-tracking branch 'origin/main' into feat/async-data-clear-fn
danielroe Mar 16, 2024
4eeaac1
docs: add docs for `clear`
danielroe Mar 16, 2024
c62ea34
Update 6.data-fetching.md
danielroe Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: cancel pending promises when clearing data
  • Loading branch information
@danielroe
danielroe committed Mar 16, 2024
commit 61c91135401ea12a0dccc947daadb43201d0dcb3
14 changes: 8 additions & 6 deletions packages/nuxt/src/app/composables/asyncData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,9 @@ export function useAsyncData<
if (value) { return value as Promise<ResT> }

const promise = nuxtApp.runWithContext(_handler)
nuxtApp.ssrContext!._sharedPrerenderCache!.set(key, promise)
return promise

nuxtApp.ssrContext!._sharedPrerenderCache!.set(key, promise)
return promise
}

// Used to get default values
Expand Down Expand Up @@ -516,10 +517,11 @@ function clearNuxtDataByKey (nuxtApp: NuxtApp, key: string): void {
}

if (nuxtApp._asyncData[key]) {
nuxtApp._asyncData[key]!.data.value = undefined
nuxtApp._asyncData[key]!.error.value = null
nuxtApp._asyncData[key]!.pending.value = false
nuxtApp._asyncData[key]!.status.value = 'idle'
(nuxtApp._asyncDataPromises[key] as any).cancelled = true
nuxtApp._asyncData[key]!.data.value = undefined
nuxtApp._asyncData[key]!.error.value = null
nuxtApp._asyncData[key]!.pending.value = false
nuxtApp._asyncData[key]!.status.value = 'idle'
}

if (key in nuxtApp._asyncDataPromises) {
Expand Down