Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): use joinRelativeURL for build assets #26282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 16, 2024
Merged

fix(nuxt): use joinRelativeURL for build assets #26282

merged 5 commits into from
Mar 16, 2024
+2 −6

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This handles relative path segments, allowing (for example) the vite manifest to refer to public assets as dependencies of source files. Necessary (for example) for nuxt/fonts#24.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 March 15, 2024 18:04
@danielroe danielroe self-assigned this Mar 15, 2024
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe mentioned this pull request Mar 15, 2024
Closed
@danielroe danielroe merged commit 0362ebf into main Mar 16, 2024
@danielroe danielroe deleted the fix/relative-build-assets branch March 16, 2024 01:31
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Merged
@MickL
Copy link

MickL commented Mar 18, 2024 •
edited
Loading

Not sure if this is related but I am getting errors with latest Nuxt 3.11.0 for mostly all of my pages:

Uncaught SyntaxError: The requested module '/_nuxt/node_modules/.cache/vite/client/deps/ufo.js?v=f3153824' does not provide an export named 'joinRelativeURL' (at paths.mjs:1:10)

Bildschirmfoto 2024-03-18 um 15 38 14

@beejaz
Copy link

beejaz commented Mar 23, 2024

I got this error on all my Vercel builds after upgrading to 3.11.0 and was not able to build the deploy.

[error] Nuxt Build Error: virtual:nuxt:/vercel/path0/.nuxt/paths.mjs (1:9): "joinRelativeURL" is not exported by "node_modules/.pnpm/[email protected]/node_modules/ufo/dist/index.mjs", imported by "virtual:nuxt:/vercel/path0/.nuxt/paths.mjs".

I downgraded Nuxt to 3.10.3, managed to deploy and then tried upgrading again to 3.11.1 and it suddenly worke. Not sure if it was fixed in 3.11.1 or if it was some cache issues with vercel. Anyway, just thought I would say it.

@danielroe
Copy link
Member Author

That error is caused by having the wrong version of ufo. Probably initially your package manager hoisted the wrong version. Then your next upgrade fixed the issue. It shouldn't persist for others if they regenerate or dedupe their lock file.

@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @MickL @beejaz