Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): correctly move v-if from slot to wrapper component #26386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 25, 2024
Merged

fix(nuxt): correctly move v-if from slot to wrapper component #26386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
800de41
fix(nuxt): correctly move v-if from slot to wrapper component
julien-huang-leetchi Mar 19, 2024
84b560c
perf: remove v-if from slot
julien-huang-leetchi Mar 19, 2024
7240187
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 19, 2024
889a99f
fix: add else and else-if directives
huang-julien Mar 23, 2024
8921ed7
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 23, 2024
9be9380
fix: fix join()
huang-julien Mar 23, 2024
50cbc07
Merge branch 'fix/slotvif' of https://github.com/nuxt/nuxt into fix/s…
huang-julien Mar 23, 2024
576e1a4
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 23, 2024
10646a8
fix: fix vfor
huang-julien Mar 23, 2024
6a26506
Merge branch 'fix/slotvif' of https://github.com/nuxt/nuxt into fix/s…
huang-julien Mar 23, 2024
e89a85b
chore: lint
huang-julien Mar 23, 2024
92bea57
fix(nuxt): allow binding with -
huang-julien Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(nuxt): allow binding with - 
Co-authored-by:  Divyansh Singh <[email protected]>
  • Loading branch information
@huang-julien @brc-dd
huang-julien and brc-dd committed Mar 24, 2024
commit 92bea574a01b3ee6f8177c0415f3ecf056412b9f
2 changes: 1 addition & 1 deletion packages/nuxt/src/components/islandsTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ function isBinding (attr: string): boolean {

function getPropsToString (bindings: Record<string, string>, vfor?: [string, string]): string {
if (Object.keys(bindings).length === 0) { return 'undefined' }
const content = Object.entries(bindings).filter(b => b[0] && b[0] !== '_bind').map(([name, value]) => isBinding(name) ? `${name.slice(1)}: ${value}` : `${name}: \`${value}\``).join(',')
const content = Object.entries(bindings).filter(b => b[0] && b[0] !== '_bind').map(([name, value]) => isBinding(name) ? `[\`${name.slice(1)}\`]: ${value}` : `[\`${name}\`]: \`${value}\``).join(',')
const data = bindings._bind ? `mergeProps(${bindings._bind}, { ${content} })` : `{ ${content} }`
if (!vfor) {
return `[${data}]`
Expand Down
6 changes: 3 additions & 3 deletions packages/nuxt/test/islandTransform.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ describe('islandTransform - server and island components', () => {
<div>
<NuxtTeleportSsrSlot name="default" :props="undefined"><slot /></NuxtTeleportSsrSlot>

<NuxtTeleportSsrSlot name="named" :props="[{ some-data: someData }]"><slot name="named" :some-data="someData" /></NuxtTeleportSsrSlot>
<NuxtTeleportSsrSlot name="other" :props="[{ some-data: someData }]"><slot
<NuxtTeleportSsrSlot name="named" :props="[{ [\`some-data\`]: someData }]"><slot name="named" :some-data="someData" /></NuxtTeleportSsrSlot>
<NuxtTeleportSsrSlot name="other" :props="[{ [\`some-data\`]: someData }]"><slot
name="other"
:some-data="someData"
/></NuxtTeleportSsrSlot>
Expand Down Expand Up @@ -99,7 +99,7 @@ describe('islandTransform - server and island components', () => {
expect(normalizeLineEndings(result)).toMatchInlineSnapshot(`
"<template>
<div>
<NuxtTeleportSsrSlot name="default" :props="[{ some-data: someData }]"><slot :some-data="someData"/><template #fallback>
<NuxtTeleportSsrSlot name="default" :props="[{ [\`some-data\`]: someData }]"><slot :some-data="someData"/><template #fallback>
<div>fallback</div>
</template></NuxtTeleportSsrSlot>
</div>
Expand Down