Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): move some directive to client component wrapper #26387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2024
Merged

fix(nuxt): move some directive to client component wrapper #26387

merged 5 commits into from
Mar 26, 2024

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

#26386

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR is the same as #26386 but for client components

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien huang-julien marked this pull request as ready for review March 19, 2024 19:51
@huang-julien huang-julien self-assigned this Mar 19, 2024
@huang-julien huang-julien marked this pull request as draft March 20, 2024 08:25
@huang-julien huang-julien changed the title fix(nuxt): correctly move v-if from client component to wrapper fix(nuxt): move some directive to client component wrapper Mar 25, 2024
@huang-julien huang-julien marked this pull request as ready for review March 25, 2024 20:52
@danielroe danielroe merged commit 67c6646 into main Mar 26, 2024
@danielroe danielroe deleted the fix/nuxt-client-vif branch March 26, 2024 13:47
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

@huang-julien huang-julien

Labels
3.x bug 🔨 p3-minor server components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huang-julien @danielroe