Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): make pageMeta ast undefineable in transformation #26388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(nuxt): make pageMeta ast undefineable in transformation #26388

wants to merge 1 commit into from

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

fix #26377

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR makes the meta AST undefineable in the transform plugin.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien huang-julien self-assigned this Mar 19, 2024
@huang-julien huang-julien marked this pull request as ready for review March 20, 2024 08:25
danielroe
danielroe reviewed Mar 20, 2024
View reviewed changes
packages/nuxt/src/pages/plugins/page-meta.ts
if (!addedImports.has(importValue)) {
contents = importMap.get(name)!.code + '\n' + contents
addedImports.add(importValue)
const meta = node.arguments[0] as (Expression & { start: number, end: number }) | undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin should already be doing it:

nuxt/packages/nuxt/src/core/plugins/tree-shake.ts

Lines 29 to 46 in ff1bb56

transform (code) {
if (!COMPOSABLE_RE.test(code)) { return }
const s = new MagicString(code)
const strippedCode = stripLiteral(code)
for (const match of strippedCode.matchAll(COMPOSABLE_RE_GLOBAL)) {
s.overwrite(match.index!, match.index! + match[0].length, `${match[1]} false && /*@__PURE__*/ ${match[2]}`)
}
if (s.hasChanged()) {
return {
code: s.toString(),
map: options.sourcemap
? s.generateMap({ hires: true })
: undefined
}
}
}

It would be worth investigating why it is not in this case.

@danielroe danielroe mentioned this pull request Mar 21, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees

@huang-julien huang-julien

Labels
3.x bug
Projects
None yet
Milestone
No milestone
2 participants
@huang-julien @danielroe