Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): pass joinRelativeURL to bundle renderer and share paths with nitro #26407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 21, 2024
Merged

fix(nuxt): pass joinRelativeURL to bundle renderer and share paths with nitro #26407

merged 11 commits into from
Mar 21, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we switched across to joinRelativeURL in build/paths.mjs but didn't do so for paths.ts which is used in the nitro renderer.

This PR:

  1. updates the implementations to be the same
  2. deduplicates these two files on the server when building

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 March 20, 2024 16:58
@danielroe danielroe self-assigned this Mar 20, 2024
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

pi0
pi0 reviewed Mar 20, 2024
View reviewed changes
@danielroe danielroe changed the title fix(nuxt): pass joinRelativeURL to bundle renderer fix(nuxt): pass joinRelativeURL to bundle renderer and share paths with nitro Mar 21, 2024
pi0
pi0 reviewed Mar 21, 2024
View reviewed changes
pi0
pi0 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒 💯

@danielroe danielroe merged commit 8c3159f into main Mar 21, 2024
@danielroe danielroe deleted the fix/relative-assets branch March 21, 2024 11:57
This was referenced Mar 21, 2024
Closed
Merged
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0