Thanks to visit codestin.com
Credit goes to github.com

Skip to content

perf(nuxt): don't tree-shake useServerHead in dev #26421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2024
Merged

perf(nuxt): don't tree-shake useServerHead in dev #26421

merged 3 commits into from
Mar 21, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 21, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Spotted this opportunity to improve performance - we deliberately do not tree-shake any other composables in dev mode, but weren't checking before inserting useServerHead.

This should mean we don't need to run that vite plugin at all and it won't be initialised:

nuxt/packages/nuxt/src/core/nuxt.ts

Lines 187 to 190 in 3c7e68c

if (Object.keys(clientTreeShakeOptions.composables).length) {
addVitePlugin(() => TreeShakeComposablesPlugin.vite(clientTreeShakeOptions), { server: false })
addWebpackPlugin(() => TreeShakeComposablesPlugin.webpack(clientTreeShakeOptions), { server: false })
}

cc: @harlan-zw in case there's a reason we should tree-shake it in dev mode

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from harlan-zw March 21, 2024 09:59
@danielroe danielroe self-assigned this Mar 21, 2024
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@harlan-zw
Copy link
Contributor

harlan-zw commented Mar 21, 2024 •
edited
Loading

Nice, can't imagine it would be an issue

danielroe
danielroe commented Mar 21, 2024
View reviewed changes
danielroe
danielroe commented Mar 21, 2024
View reviewed changes
@danielroe danielroe merged commit 57b8d97 into main Mar 21, 2024
@danielroe danielroe deleted the perf/tree-shake-head-dev branch March 21, 2024 12:17
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Merged
@BalaKadiyala BalaKadiyala mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlan-zw harlan-zw harlan-zw approved these changes

Assignees

@danielroe danielroe

Labels
3.x performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @harlan-zw