fix(nuxt): check vnode element instead of hydration state for islands #26480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Mar 25, 2024
danielroe
reviewed
Mar 25, 2024
|
Might be the same issue as vuejs/core#6638. |
|
@danielroe it probably is. Is it better to let vue/core fix it ? |
|
I think this is a good fix in the meantime. But fixing upstream would be 👌 |
Co-authored-by: Daniel Roe <[email protected]>
danielroe
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #26434
❓ Type of change
📚 Description
Hi 👋 this PR prefer using
vnode.elinstead ofnuxtApp.isHydratingNot sure why we do have this issue with
resolveComponent.This PR however fix the case where nuxtIsland is called within an async component
📝 Checklist