Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Mini-ghost
Copy link
Member

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Following PR #26392, we ignored the open option of navigate on the server side. In reality, the check for options?.open should also only be executed on the client side.

However, when we build the code and open server.js, we discover some residual code as follows:

if (options == null ? void 0 : options.open)
  ;

This PR merely attempts to clean up the leftover code.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit a33674b into nuxt:main Mar 29, 2024
@github-actions github-actions bot mentioned this pull request Mar 29, 2024
@Mini-ghost Mini-ghost deleted the refactor/navigate-concise branch February 23, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants