fix(nuxt): suppress warning about resolve cache-driver #26595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Apr 2, 2024
| 'internal:nuxt:prerender': { | ||
| driver: pathToFileURL(await resolvePath(join(distDir, 'core/runtime/nitro/cache-driver'))).href, | ||
| // TODO: resolve upstream where file URLs are not being resolved/inlined correctly | ||
| driver: isWindows ? pathToFileURL(cacheDriverPath).href : cacheDriverPath, |
There was a problem hiding this comment.
Nice idea but not sure how all rollup plugins support file URLs currently. Additionally, i think we should investigate why we need this workaround for windows in first place. nitro should normalize to file URL for windows even if driver path is absolute.
There was a problem hiding this comment.
@pi0
Still getting this warning on Windows. Have you guys had a chance to investigate this at all? Maybe fix it for Nitro 3.0?
Thank you!
pi0
approved these changes
Apr 2, 2024
songjianet
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
This suppresses this warning:
However, we need to investigate why the existing inline rule which already covers
distDirisn't working for file URLs. This is likely an upstream issue in nitro or possibly pathe/etc. (Perhaps we are wrongly callingisAbsoluteon the file URL and getting false?) (cc: @pi0)